How do you get the ID of the pressed button

Hi Russ,

I placed the

int nControlID = GetDlgCtrlID();

of each of my event handlers for the button. THe IDC value for each of the 4 buttons are

ON_BN_CLICKED(IDC_BUTTON_AUTO, OnClickAuto)
ON_BN_CLICKED(IDC_BUTTON_BLOCK, OnClickBlock)
ON_BN_CLICKED(IDC_BUTTON_CLOSED, OnClickClosed)
ON_BN_CLICKED(IDC_BUTTON_MANUAL, OnClickManual)

IDC_BUTTON_CLOSED - 2073
IDC_BUTTON_BLOCK - 2074
IDC_BUTTON_MANUAL - 2075
IDC_BUTTON_AUTO - 2076

When I click on any of the button, I was hoping to get values from 2073-2076, which is the pressed button ID value. However, I get '59648' on any of the 4 pressed button. I was hoping if I click the Auto button, the function returns a 2076.

Am I doing something wrong?

Thanks,

Rage

What are you trying to do, that you need the button's control id within it's own OnClick handler?

If you just want to trace all button clicks within your dialog (aside from the OnClick handlers for the buttons) you could override WindowProc for your dialog and do something like this.

LRESULT CMainDlg::WindowProc(UINT message, WPARAM wParam, LPARAM lParam)
{
#ifdef _DEBUG
if (message == WM_COMMAND)
if (HIWORD(wParam) == BN_CLICKED)
{
CString strCtrlID;
strCtrlID.Format("CtrlID: %d\r\n",LOWORD(wParam));
TRACE(strCtrlID);
}
#endif
return CDialog::WindowProc(message, wParam, lParam);
}

This will print the Control ID's of the button that was clicked (whenever a button is clicked) to the VS output window. Of course this would be just for testing (debugging) purposes.

That sounds strange. Are you handling OnLButtonDown too (or any other button messages?) or just On_Button_Clicked?

Are all your buttons normal CButton's, or are you using some other type of button (or button class/derived button class)?

How are you verifying this? Are you just examining data (or visual cues) after clicking a couple of buttons, or did you actually set breakpoints on each of your button's OnClick handlers and verify that way?

It is strange. I never seen this before or heard of it. All the buttons are CBitmapbutton created dynamically with the Create call. I used ON_BN_CLICKED in the Message_Map section.

I placed all debug stop buttons and if I click on the 2nd, 3rd, so on, it will first called the last button event handler function and the correct button function. I verified this with GetCurrentMessage and saw the last button ID in the wparam when it calls the last button event handler and then the correct function call.

Strange,

-Rage

Since everything had to be dynamically created, I add everything manually.

Thanks Russ,

I comment all the code out and found out that CButton->SetState(...) was causing the problem.

Strange,

-Rage